Add inner product and cosine similarity optimizations#7364
Merged
connortsui20 merged 3 commits intodevelopfrom Apr 9, 2026
Merged
Add inner product and cosine similarity optimizations#7364connortsui20 merged 3 commits intodevelopfrom
connortsui20 merged 3 commits intodevelopfrom
Conversation
gatesn
approved these changes
Apr 9, 2026
connortsui20
commented
Apr 9, 2026
Comment on lines
+229
to
+234
| if !matches!(validity, Validity::NonNullable) { | ||
| // Masking always changes the nullability to nullable. | ||
| dot.mask(validity.to_array(len)) | ||
| } else { | ||
| Ok(dot) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is kind of awful
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/math-opt
branch
from
b5021d1 to
79cb061
Compare
Merging this PR will improve performance by 29.94%
Performance Changes
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds compute optimizations for the
InnerProductandCosineSimilaritychanges, mostly related to when a child has already been decomposed into normalized and norms viaL2Denormscalar fn array.Testing
Adds some more tests.